-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow escaped quotes in tag parameters #124
Conversation
@roya1v why not use |
@0xTim that was my initial idea. As far as I tried we don't distinguish between escaped and not-escaped quotes. I tried to dig deeper but couldn't find a place in leaf-kit to amend this behaviour. Correct me please if I'm wrong Now that I think about it, two slashes might work, lmk if you would prefer that |
Ah I see, I think the issue you're having is that Swift will automatically count the |
Hey @0xTim sorry I don't know if you didn't see it or didn't have time to take a look. I've pushed the change to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 82.09% 81.51% -0.59%
==========================================
Files 25 25
Lines 2603 2510 -93
==========================================
- Hits 2137 2046 -91
+ Misses 466 464 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry it's taken so long to review!
These changes are now available in 1.10.6
Allows escaped quotes in tag parameters so you can do something like
#myCustomTag("this \"thing\" is cool")
Solves #122